Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Fix incorrect encoding-aware name truncation in - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Fix incorrect encoding-aware name truncation in
Date
Msg-id 20090816181446.A4BCD75331E@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Fix incorrect encoding-aware name truncation in makeArrayTypeName().

truncate_identifier won't do anything if the passed-in strlen is already
less than NAMEDATALEN, which it always would be given the strlcpy usage.
This has been broken since the arrays-of-composite-types code went in.

Arguably truncate_identifier is suffering from excessive optimization
and should always process the string, but for the moment I'll take the
more localized patch.

Per bug #4987.

Tags:
----
REL8_3_STABLE

Modified Files:
--------------
    pgsql/src/backend/catalog:
        pg_type.c (r1.115.2.1 -> r1.115.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_type.c?r1=1.115.2.1&r2=1.115.2.2)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix incorrect encoding-aware name truncation in
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix imprecise documentation of random(): it never returns 1.0.