Brendan Jurd escribió:
> 2009/8/9 Alvaro Herrera <alvherre@commandprompt.com>:
> > I noticed an ugly pattern in NUMDesc_prepare calling a cleanup function
> > before every ereport(ERROR). I think it's cleaner to replace that with
> > a PG_TRY block; see attached.
>
> Looks nice -- although doesn't have anything to do with the EEEE patch
> so perhaps deserves its own thread?
Yes, it just popped up while skimming the patch.
> > I didn't go over the patch in much more detail. (But the
> > numeric_out_sci business got me thinking.)
>
> Got you thinking about what? I'd welcome any comments you have.
I wondered if it should just return char *. If we want to have this
functionality as its own fmgr-blessed function, shouldn't it return
text instead of cstring?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
