Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros - Mailing list pgsql-hackers

From Jeremy Kerr
Subject Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros
Date
Msg-id 200907151042.07891.jk@ozlabs.org
Whole thread Raw
In response to Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Hi, Alvaro,

> Does this work in compilers other than GCC?  I think we use some
> kludges to protect against them ... see pg_list.h for the canonical
> example.

As I understand it, we're not using static inlines in pg_list.h to 
prevent multiple objects from exporting the same symbols if the 
functions don't end up as 'static inline' (ie, because the compiler 
doesn't support that).

In this case, we're only compiling the inlines into a single object, so 
even if the compiler doesn't support inlines, we'll just end up with 
out-of-line function calls, which should work too.

However, this is only my assumption about those compilers (I don't have 
access to other compilers to test); happy to fix these up if the inlines 
won't work.

Cheers,


Jeremy


pgsql-hackers by date:

Previous
From: Glen Parker
Date:
Subject: Re: more than one index in a single heap pass?
Next
From: Greg Stark
Date:
Subject: Re: Index-only scans