Re: Win32 link() function - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Win32 link() function
Date
Msg-id 200906021515.n52FF7w05270@momjian.us
Whole thread Raw
In response to Win32 link() function  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
bruce wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Tom Lane wrote:
> > >> (Come to think of it, --link can fail on Unix too, if the user tries to
> > >> put the new database on a different filesystem.  Have you got guards in
> > >> there to make sure this is discovered before the point of no return?)
> > 
> > > Of course:
> > > ...
> > > though you have to delete the new cluster directory and remove the _old
> > > suffixes to get your old cluster back.
> > 
> > That wasn't what I had in mind by "before the point of no return".
> > You should be making some effort to detect obvious failure cases
> > *before* the user has to do a lot of error-prone manual cleanup.
> 
> That is something I will address during beta as I get problem reports.

I have implemented your suggestion:
Stopping postmaster servicing old cluster                   okStarting postmaster to service new cluster  waiting for
postmasterto start                           okStopping postmaster servicing new cluster                   okCould not
createhard link between old and new data directories: Cross-device linkIn link mode the old and new data directories
mustbe on the same filesystem volume.
 

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PostgreSQL Developer meeting minutes up
Next
From: Bruce Momjian
Date:
Subject: Re: pg_migrator and making columns invisible