On Mon, Apr 27, 2009 at 01:31:11PM -0400, Alvaro Herrera wrote:
> David Fetter wrote:
> > On Mon, Apr 27, 2009 at 01:11:44PM -0400, Tom Lane wrote:
>
> > > It seems like rather a large change to be making in beta. Can
> > > you make a small patch that fixes the immediate problem, and
> > > leave the refactoring for 8.5?
> >
> > The hack I've come up with short of the refactor is to duplicate a
> > lot of the backslash handling code from command.c and describe.c.
> > It doesn't strike me as being all that much less work than the
> > refactor.
>
> Tab completion has never been perfect. I don't think beta is the
> best time to be improving it so much. I think a small patch that
> just adds "\dfa", "\dfw" and appropriate pattern completions (i.e.
> it lists window functions in \dfw, etc) should be enough for now,
> and let the big refactoring loose in the 8.5 timeframe. If we don't
> support \dfaw in 8.4, tough world.
The problem I see that argues for a refactor is the S option. Short
of the refactor, how do I handle it?
Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
