Re: reloptions with a "namespace" - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: reloptions with a "namespace"
Date
Msg-id 20090403200647.GN23023@alvh.no-ip.org
Whole thread Raw
In response to Re: reloptions with a "namespace"  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: reloptions with a "namespace"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane escribió:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > This patch seems to be the right cure.  (Some other users of
> > opt_definition remain; I think it's just CREATE FUNCTION by now).
> 
> Surely this will break other things.  I find myself wondering why you
> invented ReloptElem at all, instead of adding a field to DefElem.

I had to, precisely because it messes up other uses of DefElem ...

For example, the grammar would allow
CREATE FUNCTION ... WITH something.name = value
which we certainly don't want.

I don't expect to break anything else actually.  Keep in mind that those
"opt_definition" were there precisely to carry reloptions for the
affected indexes.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: reloptions with a "namespace"
Next
From: Tom Lane
Date:
Subject: Re: reloptions with a "namespace"