Re: typedefs for indent - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: typedefs for indent
Date
Msg-id 20090322190122.GB16373@alvh.no-ip.org
Whole thread Raw
In response to Re: typedefs for indent  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: typedefs for indent  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > [ typedef lists ]
> 
> Hmm ... the windows members are claiming that "int", "char", "float",
> "double" etc are typedefs, which doesn't exactly match up with my
> mental model of C.

I don't think this is a problem, because the whole point is telling
indent what names should be considered type names, which of course those
should all be.

> On the other hand, dungbeetle is failing to report
> a whole bunch of typedefs that it should report, for example
> AfterTriggerEventDataOneCtid which comes from entirely non platform
> specific code in commands/trigger.c.

This was probably optimized out by the compiler.

I tend to think that having this list is much better than no list at all
(the current situation), and it's better than the old list we used to
have.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: poor wording on SSPI error message
Next
From: Tom Lane
Date:
Subject: Re: typedefs for indent