Re: PQinitSSL broken in some use casesf - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: PQinitSSL broken in some use casesf
Date
Msg-id 200902110417.n1B4HlX29802@momjian.us
Whole thread Raw
In response to Re: PQinitSSL broken in some use casesf  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Andrew Chernow wrote:
> > 
> > > On Tue, Feb 10, 2009 at 5:02 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > >> PQinitSSL(false) initializes crypto?  Please point me to exact function
> > >> calls that are the problem?  Everything is very vague.
> > 
> > File: src/interfaces/libpq/fe-secure.c
> > Func: init_ssl_system
> > Line: 823
> > 
> > Starting at around line 853, this function prepares a lock array for 
> > CRYPTO_set_locking_callback.  This function is not part of libssl, its 
> > part of libcrypto.  It also calls CRYPTO_set_id_callback.  The rest of 
> > that function appears to only make libssl calls.
> > 
> > There should be an "if (pq_initcryptolib)" around those libcrypto calls, 
> > serving the same purpose as the pq_initssllib variable.
> 
> Why not just call PQinitSSL(true) and do everything in your

Sorry, meant 'false'.  Also, I read Merlin's comments and understand he
doesn't want his application to have to set up SSL.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PQinitSSL broken in some use casesf
Next
From: Tom Lane
Date:
Subject: Re: GIN fast insert