Re: AIX 4.3 getaddrinfo busted - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: AIX 4.3 getaddrinfo busted
Date
Msg-id 200901231421.n0NELgN19695@momjian.us
Whole thread Raw
In response to AIX 4.3 getaddrinfo busted  (Andrew Chernow <ac@esilo.com>)
Responses Re: AIX 4.3 getaddrinfo busted
List pgsql-hackers
Andrew Chernow wrote:
> AIX 4.3 was released in late 1999, so I thought it was worth mentioning. 
>   I only have AIX 4.3 and 6.1, so I have no idea how AIX 5 handles this. 
>   AIX 6.1 works fine.
> 
> Anyways, the service argument to getaddrinfo is busted on AIX 4.3, thus 
>   src/backend/libpq/ip.c pg_getaddrinfo_all() is busted on this 
> platform.  It fails with EAI_NODATA "Host not found".   If this argument 
> is left NULL, everything works.
> 
> I can supply a patch to fix this.  My suggestion would be to always 
> supply a NULL service to getaddrinfo.  After a successful call, set the 
> port if it was provided ... htons((unsigned short)atoi(servname)).  This 
> approach avoids a configure check.

Why would we risk breaking other platforms to avoid an AIX bug?  At best
we can put a code comment in that section of the code.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Andrew Chernow
Date:
Subject: AIX 4.3 getaddrinfo busted
Next
From: Christopher Browne
Date:
Subject: Re: AIX 4.3 getaddrinfo busted