Martijn van Oosterhout wrote:
> On Tue, Jan 13, 2009 at 10:05:45AM -0300, Alvaro Herrera wrote:
> > pgace.h: you have a bunch of "static inline" functions in here. As far
> > as I know this doesn't work in compilers other than GCC :-( See
> > pg_list.h (list_head) for an example. I think we can tolerate this for
> > the three functions in pg_list.h because they are so few and so tiny,
> > but I'm not sure about PGACE because they are a large lot. On the other
> > hand, turning them to real functions would be a performance hit.
>
> Really? C99 requires it and MSVC does support it.
Apparently we're stuck with C89 for some time yet; maybe an upgrade can
be argued, if a large gain by the jump to C99 can be demonstrated:
http://archives.postgresql.org/pgsql-hackers/2008-11/msg01494.php
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
