Re: Fix for compiler warning in reloptions.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Fix for compiler warning in reloptions.c
Date
Msg-id 20090106030645.GK7345@alvh.no-ip.org
Whole thread Raw
In response to Fix for compiler warning in reloptions.c  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Fix for compiler warning in reloptions.c
List pgsql-hackers
Bruce Momjian wrote:
> The attached applied patch prevents a compiler warning;  the compiler
> doesn't know about our elog(ERROR) exit case.

Hmm, I don't like your fix; ISTM it would be better to set the variable
only in the default: case (or maybe change the "break" for a "return").

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: version() output vs. 32/64 bits
Next
From: Bruce Momjian
Date:
Subject: Re: contrib Japanese README