Re: [PATCH] Check operator when creating unique index on partition table - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Check operator when creating unique index on partition table
Date
Msg-id 20082.1585767189@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Check operator when creating unique index on partitiontable  (Guancheng Luo <prajnamort@gmail.com>)
List pgsql-hackers
Guancheng Luo <prajnamort@gmail.com> writes:
> On Mar 26, 2020, at 01:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This would reject, for example, a hash index associated with a btree-based
>> partition constraint, but I'm not sure we're losing anything much thereby.

> There is cases when a BTREE index associated with a HASH partition key, but I think we should allow them,
> as long as their equality operators consider the same value as equal.

Ah, yeah, I see we already have regression test cases that require that.

I pushed the patch with some cosmetic revisions.  I left out the
regression test case though; it seemed pretty expensive considering
that the code is already being exercised by existing cases.

Thanks for the report and patch!

            regards, tom lane



pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: BUG #16109: Postgres planning time is high across version (Exposebuffer usage during planning in EXPLAIN)
Next
From: John Naylor
Date:
Subject: Re: tweaking perfect hash multipliers