Re: [PATCHES] odd output in restore mode - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] odd output in restore mode
Date
Msg-id 200812152115.mBFLFpV20891@momjian.us
Whole thread Raw
In response to Re: [PATCHES] odd output in restore mode  (Martin Zaun <Martin.Zaun@Sun.COM>)
Responses Re: [PATCHES] odd output in restore mode  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Martin Zaun wrote:
> 4. Issue: missing break in switch, silent override of '-l' argument?
> 
> This behaviour has been in there before and is not addresses by the
> patch: The user-selected Win32 "mklink" command mode is never applied
> due to a missing 'break' in CustomizableInitialize():
> 
>      switch (restoreCommandType)
>      {
>          case RESTORE_COMMAND_WIN32_MKLINK:
>              SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath);
>          case RESTORE_COMMAND_WIN32_COPY:
>              SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath);
>              break;

I have added the missing 'break' to CVS HEAD;  thanks.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Josh Berkus
Date:
Subject: Re: Sync Rep: First Thoughts on Code
Next
From: Ron Mayer
Date:
Subject: Re: Sync Rep: First Thoughts on Code