Re: new patch for index DESC/NULLS FIRST/NULLS LAST - Mailing list pgadmin-hackers

From Quan Zongliang
Subject Re: new patch for index DESC/NULLS FIRST/NULLS LAST
Date
Msg-id 20081122180817.8682.4125B4E5@gmail.com
Whole thread Raw
In response to Re: new patch for index DESC/NULLS FIRST/NULLS LAST  ("Dave Page" <dpage@pgadmin.org>)
Responses Re: new patch for index DESC/NULLS FIRST/NULLS LAST  ("Dave Page" <dpage@pgadmin.org>)
List pgadmin-hackers
> That code could use some formatting changes though
> We also try to leave empty lines between distinct blocks of code to
> aid readability.

Done.

> - lstColumns should always display the order and nulls values
> - The NULLs radio buttons should not have a shaded box around them.
> - I think the dialogue design would look nicer if the DESC and and
> NULLs options were on the same horizontal alignment, eg:
>
> DESC []        NULLs    O FIRST    O LAST

Done.

> - When creating an index with one column, using DESC, I clicked on the
> SQL tab and got an assert:

I don't get it in Windows XP.
Maybe, when there is default value, my code don't invoke wxListView's
SetItem() and left original value. Is it NULL in Mac?


-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com
CIT Japan:  http://www.cit.co.jp
CIT China:  http://www.citbj.com.cn

Attachment

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Buglets in dlgFunction
Next
From: "Tomasz Zeman"
Date:
Subject: pgAgent 2.0.0 compilation errors (types casting)