pgsql: In predtest.c, install a limit on the number of branches we will - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: In predtest.c, install a limit on the number of branches we will
Date
Msg-id 20081112230855.F3EA87545A4@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
In predtest.c, install a limit on the number of branches we will process in
AND, OR, or equivalent clauses: if there are too many (more than 100) just
exit without proving anything.  This ensures that we don't spend O(N^2) time
trying (and most likely failing) to prove anything about very long IN lists
and similar cases.

Also, install a couple of CHECK_FOR_INTERRUPTS calls to ensure that a long
proof attempt can be interrupted.

Per gripe from Sergey Konoplev.

Back-patch the whole patch to 8.2 and just the CHECK_FOR_INTERRUPTS addition
to 8.1.  (The rest of the patch doesn't apply cleanly, and since 8.1 doesn't
show the complained-of behavior anyway, it doesn't seem necessary to work
hard on it.)

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/backend/optimizer/util:
        predtest.c (r1.4 -> r1.4.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/predtest.c?r1=1.4&r2=1.4.2.1)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: In predtest.c, install a limit on the number of branches we will
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Arrange to cache the results of looking up a btree predicate