Postgres Pro
Downloads
Home   >   mailing lists

Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
Date
Msg-id 20081020212322.GG4116@alvh.no-ip.org
Whole thread Raw
Responses Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
List pgsql-hackers
Tree view 
Alvaro Herrera wrote:
> Log Message:
> -----------
> Properly access a buffer's LSN using existing access macros instead of abusing
> knowledge of page layout.

Hmm, I just noticed this comment in bufpage.h (which was also in Jonah's
patch) :-(

typedef struct PageHeaderData
{   /* XXX LSN is member of *any* block, not only page-organized ones */   ...


So I'm now wondering if the above patch is really correct.  It'll of
course work, but is it appropriate?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: [GENERAL] Hot Standby utility and administrator functions
Next
From: "Jonah H. Harris"
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros