Re: autovacuum and reloptions - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: autovacuum and reloptions
Date
Msg-id 20081008151022.GB4164@alvh.no-ip.org
Whole thread Raw
In response to Re: autovacuum and reloptions  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: autovacuum and reloptions
List pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > On second look, however, the problem is that I seem to be
> > forced to declare all the autovacuum-related options and their parsing
> > properties in reloptions.c.  This seems very ugly.
> 
> That was in fact the intended design, and is why the functions exist in
> a separate file reloptions.c rather than having been dumped into some
> existing place like heapam.c.  I don't see anything very wrong with
> having autovacuum options in StdRdOptions and default_reloptions().

Hmm, OK.  However, given that the various AMs amoptions also use
default_reloptions, they are going to accept the autovacuum options too.
Is that OK?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: autovacuum and reloptions
Next
From: Tom Lane
Date:
Subject: Re: autovacuum and reloptions