[Patch Review] Copy column storage parameters on CREATE TABLE LIKE/INHERITS - Mailing list pgsql-hackers

From Stephen Frost
Subject [Patch Review] Copy column storage parameters on CREATE TABLE LIKE/INHERITS
Date
Msg-id 20080909023533.GT16005@tamriel.snowman.net
Whole thread Raw
In response to Copy column storage parameters on CREATE TABLE LIKE/INHERITS  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-hackers
Greetings,
 I've reviewed the patch here: http://archives.postgresql.org/message-id/20080812170932.8E65.52131E4D@oss.ntt.co.jp
 and am happy to report that it looks to be in good order.  It has documentation and regression updates, is in context
diffformat, patches against current CVS with only some minor fuzz, and appears to work as advertised.  I looked over
thepatch and could easily follow what was going on, did some additional testing beyond the regression tests, and
reviewedthe documentation changes. 
 My only comment on this patch is that the documentation updates might include a link back to Section 53.2 for more
information,and/or to the SET STORAGE portion of the alter table/alter column command documentation, since the only
other'storage' reference in create table's documentation is about table storage parameters.      Thanks! 
    Stephen

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: sql2008 diff sql2003
Next
From: Alvaro Herrera
Date:
Subject: Re: [gsmith@gregsmith.com: Re: [patch] GUC source file and line number]