Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be
Date
Msg-id 20080829162252.GG3983@alvh.no-ip.org
Whole thread Raw
Responses Re: Re: [COMMITTERS] pgsql: Remove all traces that suggest that a non-Bison yacc might be  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Peter Eisentraut wrote:
> Log Message:
> -----------
> Remove all traces that suggest that a non-Bison yacc might be supported, and 
> change build system to use only Bison.  Simplify build rules, make file names 
> uniform.  Don't build the token table header file where it is not needed.

I'm finding that this patch is needed to make this build on VPATH:

Index: src/backend/parser/Makefile
===================================================================
RCS file: /cvsroot/pgsql/src/backend/parser/Makefile,v
retrieving revision 1.47
diff -c -p -r1.47 Makefile
*** src/backend/parser/Makefile 29 Aug 2008 13:02:32 -0000      1.47
--- src/backend/parser/Makefile 29 Aug 2008 16:17:16 -0000
*************** subdir = src/backend/parser
*** 10,16 **** top_builddir = ../../.. include $(top_builddir)/src/Makefile.global 
! override CPPFLAGS := -I$(srcdir) $(CPPFLAGS)  OBJS= analyze.o gram.o keywords.o parser.o parse_agg.o parse_clause.o \
     parse_expr.o parse_func.o parse_node.o parse_oper.o parse_relation.o \
 
--- 10,16 ---- top_builddir = ../../.. include $(top_builddir)/src/Makefile.global 
! override CPPFLAGS := -I$(srcdir)/.. $(CPPFLAGS)  OBJS= analyze.o gram.o keywords.o parser.o parse_agg.o
parse_clause.o\       parse_expr.o parse_func.o parse_node.o parse_oper.o parse_relation.o \
 


The problem is that keywords.c is #including "parser/gram.h" but since
we're doing a -I.../backend/parser then it doesn't find it.

I don't understand why it was working previously.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: New FSM allocation policy
Next
From: "Jaime Casanova"
Date:
Subject: Re: Proposal: new border setting in psql