pgsql: Fix a subtle bug exposed by recent wal_sync_method - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Fix a subtle bug exposed by recent wal_sync_method
Date
Msg-id 20080517172457.6A9CC754C54@cvs.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Fix a subtle bug exposed by recent wal_sync_method rearrangements.
Formerly, the default value of wal_sync_method was determined inside xlog.c,
but now it is determined inside guc.c.  guc.c was reading xlogdefs.h
without having read <fcntl.h>, leading to wrong determination of
DEFAULT_SYNC_METHOD.  Obviously xlogdefs.h needs to include <fcntl.h>
for itself to ensure stable results.

Modified Files:
--------------
    pgsql/src/backend/access/transam:
        xlog.c (r1.310 -> r1.311)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c?r1=1.310&r2=1.311)
    pgsql/src/include/access:
        xlogdefs.h (r1.21 -> r1.22)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/xlogdefs.h?r1=1.21&r2=1.22)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Remove DEFAULT_SYNC_FLAGBIT ...
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix utterly-bogus code for computing row heights.