Re: Patch to change psql default banner v6 - Mailing list pgsql-patches

From David Fetter
Subject Re: Patch to change psql default banner v6
Date
Msg-id 20080516053838.GA22821@fetter.org
Whole thread Raw
In response to Re: Patch to change psql default banner v6  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Patch to change psql default banner v6
List pgsql-patches
On Fri, May 16, 2008 at 01:22:55AM -0400, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > I believe there's a bug in this patch, namely that the warnings when
> > there's a server-client mismatch only appear at startup time.
>
> Please do not blame this patch for a problem that has been there all
> along.
>
> I don't say that the point doesn't need investigation, but blaming
> the patch-at-hand for the issue is just misleading.

The patch at hand, as you point out, emphasizes a problem that's been
there all along, namely that \c doesn't do the same things that
command line connection does.

I'm volunteering to make them use the same methods :)

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

pgsql-patches by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: Partial match in GIN (next vesrion)
Next
From: Tom Lane
Date:
Subject: Re: Patch to change psql default banner v6