Re: Patch to change psql default banner v6 - Mailing list pgsql-patches

From Joshua D. Drake
Subject Re: Patch to change psql default banner v6
Date
Msg-id 20080515090247.3ff9b08b@jd-laptop
Whole thread Raw
In response to Re: Patch to change psql default banner v6  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
On Thu, 15 May 2008 11:46:41 -0400 (EDT)
Bruce Momjian <bruce@momjian.us> wrote:

> > Bruce with respect the only useful thing I have seen you do to the
> > patch in all this wrangling is realign the \? General options and
> > frankly even that is suspect in my opinion. Can we either throw it
> > away and say, "Nice try JD" or just commit the thing.
>
> Your patch is getting the same review any other patch would have.  If
> you want someone else to apply it I will stop working on it.

I am not asking you to not review the patch. I am asking you to be
productive in doing so.  Your review of this patch is basically, "Even
though there were two very long threads with several (on the greater
side of several) different people contributing feedback, I think I know
better".

That behavior is frustrating, especially when I took an extreme amount
of effort to address all concerns ahead of the actual commit fest. I
wanted to make sure the patch would be easy to review and easy to
commit. If I thought I was going to have to have the argument all over
again, I just would have left the first submission as it was and then
we could have burned all the time during commit fest only.

Now Alvaro, Tom and I are all having the same discussion all over again
but this time with Bruce. It makes no sense.

Sincerely,

Joshua D. Drake

--
The PostgreSQL Company since 1997: http://www.commandprompt.com/
PostgreSQL Community Conference: http://www.postgresqlconference.org/
United States PostgreSQL Association: http://www.postgresql.us/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate



Attachment

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Patch to change psql default banner v6
Next
From: Alvaro Herrera
Date:
Subject: Re: Patch to change psql default banner v6