What to do with inline warnings? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject What to do with inline warnings?
Date
Msg-id 200805141808.09837.peter_e@gmx.net
Whole thread Raw
Responses Re: What to do with inline warnings?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
What do we do with warnings generated by -Winline?

I see this now:

gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-fwrapv -g -Werror -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2   -c -o 
 
tuplesort.o tuplesort.c -MMD -MP -MF .deps/tuplesort.Po
cc1: warnings being treated as errors
tuplesort.c: In function ‘comparetup_index_btree’:
tuplesort.c:2474: error: inlining failed in call to ‘myFunctionCall2’: --param large-stack-frame-growth limit reached
tuplesort.c:2525: error: called from here
tuplesort.c:2474: error: inlining failed in call to ‘myFunctionCall2’: --param large-stack-frame-growth limit reached
tuplesort.c:2525: error: called from here

and this:

gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-fwrapv -g -Werror -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2   -c -o 
 
tqual.o tqual.c -MMD -MP -MF .deps/tqual.Po
cc1: warnings being treated as errors
tqual.c: In function ‘HeapTupleSatisfiesVacuum’:
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1057: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1061: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1073: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1077: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1092: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1099: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1146: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1164: error: called from here
tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is unlikely and code size would grow
tqual.c:1171: error: called from here


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib
Next
From: Peter Eisentraut
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Improve logic for finding object files on OBJS lines in contrib