Re: bloated heapam.h - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: bloated heapam.h
Date
Msg-id 20080512002853.GD5746@alvh.no-ip.org
Whole thread Raw
In response to Re: bloated heapam.h  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: bloated heapam.h  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: bloated heapam.h  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-hackers
Alvaro Herrera wrote:

> Oops :-(  I just noticed that I removed bufmgr.h from bufpage.h, which
> is a change you had objected to previously :-(

However, it seems the right fix is to move BufferGetPageSize and
BufferGetPage from bufpage.h to bufmgr.h.

(Digging further, it seems like bufpage.h should also include transam.h
in order to get TransactionIdIsNormal ... I start to wonder how many
problems of this nature we have on our headers.  Without having a way to
detect whether the defined macros are valid, it seems hard to check
programatically, however.)

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: bloated heapam.h
Next
From: Tom Lane
Date:
Subject: Re: bloated heapam.h