Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[]) - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Date
Msg-id 20080428205514.GH5761@alvh.no-ip.org
Whole thread Raw
In response to Removing typename from A_Const (was: Empty arrays with ARRAY[])  ("Brendan Jurd" <direvus@gmail.com>)
Responses Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])
List pgsql-hackers
Alvaro Herrera escribió:
> Tom Lane escribió:
> > Alvaro Herrera <alvherre@commandprompt.com> writes:
> > > Tom Lane escribió:
> > >> They're logically different things, and after I get done putting a parse
> > >> location field into A_Const, they'll still be physically different too.
> >
> > > Aha.  Are you working from Brendan's patch?  I was going to commit it.
> >
> > Sure, go ahead.  I was going to add the parse location at the same time,
> > but it can perfectly well be done as a separate patch.
>
> I came up with the attached patch.  I added the location bits (although
> I am unsure if I got the locations right in the parser), but they are
> unused -- figuring out how to use them would take me longer than I can
> to spend on this.

Hmm, I'm now wondering if the location should be added to Value as well,
so that it can be passed down to Const?

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

pgsql-hackers by date:

Previous
From: PFC
Date:
Subject: Re: Protection from SQL injection
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])