Alvaro Herrera wrote:
> Magnus Hagander wrote:
>
> > Applied with some minor changes to the error messages to make them
> > closer to our guidelines. (With my track record, it's not entirely
> > unlikely that someone will fix them further though :-P)
>
> I think the messages should not have a newline in the middle.
Are you talking about the one in pg_ctl? We have other messages in
pg_ctl that already do this, so I figured it was ok there...
> Also, I am wondering if in PM_WAIT_BACKUP mode we should accept new
> connections from superusers only.
Oh yeah, bleh, that reminds me that I should send off the couple of
comments for further improvements I thought of.
One was just this.
Another was, should we expose the cancel backup as a SQL level command?
//Magnus
