Re: pgsql: Make float4byval and float8byval configurable on MSVC. - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Make float4byval and float8byval configurable on MSVC.
Date
Msg-id 20080421192633.27d5b3cc@mha-laptop
Whole thread Raw
In response to Re: pgsql: Make float4byval and float8byval configurable on MSVC.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Magnus Hagander wrote:
> >> Make float4byval and float8byval configurable on MSVC.
>
> > Should we now remove the entries for these 2 defines in
> > pg_config.h.win32 ?
>
> It looked to me like the patch-as-applied relied on their being there.
> I thought it was a bit ugly though.  +1 for reverting my change to
> pg_config.h.win32 and making the script insert the correct #defines in
> all four cases.

It does rely on it, because I thought it was needed by the mingw port.
And yes, I realise that makes no sense at all, now that I think about
it :-) Will fix.

//Magnus

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Make float4byval and float8byval configurable on MSVC.
Next
From: mha@postgresql.org (Magnus Hagander)
Date:
Subject: pgsql: Clean up float4byval and float8byval handling by dealing with