Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
Date
Msg-id 20080421120229.09a6e9a6@mha-laptop
Whole thread Raw
In response to Re: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a  (Magnus Hagander <magnus@hagander.net>)
List pgsql-committers
Magnus Hagander wrote:
> Andrew Dunstan wrote:
> >
> >
> > Tom Lane wrote:
> > > Log Message:
> > > -----------
> > > Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
> > > stopgap measure to get the Windows buildfarm members working
> > > again.  I don't know if it's worth exposing these as
> > > configurables, or exactly how to do it in the MSVC build
> > > system ...
> > >
> > >
> > >
> >
> > see src/tools/msvc/Solution.pm
> >
> > The options are picked up from config.pl (which is the equivalent
> > of configure invocation options) in the new() subroutine, and the
> > config files are written accordingly in the GenerateFiles()
> > subroutine.
> >
> > In general I'm in favor of keeping these as closely aligned as
> > possible.
>
> Agreed. If it's a configurable option in the autoconf system, it
> should be in the msvc one. I'll see if I can get this done during the
> day today before you guys wake up again ;-)

Done.

//Magnus

pgsql-committers by date:

Previous
From: mha@postgresql.org (Magnus Hagander)
Date:
Subject: pgsql: Make float4byval and float8byval configurable on MSVC.
Next
From: mha@postgresql.org (Magnus Hagander)
Date:
Subject: pgsql: Fix typo, noted by Stefan Kaltenbrunner.