Re: actualized SQL/PSM patch - Mailing list pgsql-patches

From Joshua D. Drake
Subject Re: actualized SQL/PSM patch
Date
Msg-id 20080402193400.3537d601@commandprompt.com
Whole thread Raw
In response to Re: actualized SQL/PSM patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: actualized SQL/PSM patch
List pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 01 Apr 2008 17:55:45 -0400
Tom Lane <tgl@sss.pgh.pa.us> wrote:

> "Pavel Stehule" <pavel.stehule@gmail.com> writes:
> > I actualized sql/psm patch. This patch can be downloaded from
> > http://www.pgsql.cz/patches/plpgpsm.diff.gz
> 
> The fundamental problem I've got with this patch is that it adds 400K
> of new code (and that's just the code, not counting documentation or
> regression tests) that we'll have to maintain, to obtain a feature
> that so far as I've heard there is precisely zero demand for.

That is likely because everyone knew he was working on it. Consider
this my +1 for pl/psm support.

> 
> The duplicativeness of the code with plpgsql doesn't make this
> prospect any more pleasant, either.

However, I do agree with you here. I would much prefer it be cleaned up
into its own space.

> 
> The idea would be a lot easier to swallow if the code were refactored
> to avoid the duplication with plpgsql.

+1.

Sincerely,

Joshua D. Drake


- -- 
The PostgreSQL Company since 1997: http://www.commandprompt.com/ 
PostgreSQL Community Conference: http://www.postgresqlconference.org/
United States PostgreSQL Association: http://www.postgresql.us/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFH9EIYATb/zqfZUUQRAmkiAJ9Q5s2Lsit7lW60sczr1/wxEGX2LACdH2rl
079G3tiL/Jj+B7FU6G5e65c=
=nnba
-----END PGP SIGNATURE-----

pgsql-patches by date:

Previous
From: Gregory Stark
Date:
Subject: Re: Consistent \d commands in psql
Next
From: Andrew Dunstan
Date:
Subject: Re: actualized SQL/PSM patch