Re: Remove ipcclean - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Remove ipcclean
Date
Msg-id 200803261519.m2QFJAS17514@momjian.us
Whole thread Raw
In response to Remove ipcclean  (Bruce Momjian <bruce@momjian.us>)
List pgsql-patches
Bruce Momjian wrote:
> There are patch queue comments suggesting the removal of the ipcclean
> command-line utility.  ipcclean doesn't work on Windows, and it probably
> doesn't work perfectly all Unixes either.
>
> The attached patch removes the utility, though some files will have to
> be removed as well.

Sorry, right patch attached this time.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: doc/src/sgml/reference.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/reference.sgml,v
retrieving revision 1.65
diff -c -c -r1.65 reference.sgml
*** doc/src/sgml/reference.sgml    21 Aug 2007 21:08:47 -0000    1.65
--- doc/src/sgml/reference.sgml    26 Mar 2008 14:50:28 -0000
***************
*** 211,217 ****
    </partintro>

     &initdb;
-    &ipcclean;
     &pgControldata;
     &pgCtl;
     &pgResetxlog;
--- 211,216 ----
Index: doc/src/sgml/ref/allfiles.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/allfiles.sgml,v
retrieving revision 1.72
diff -c -c -r1.72 allfiles.sgml
*** doc/src/sgml/ref/allfiles.sgml    21 Aug 2007 21:08:47 -0000    1.72
--- doc/src/sgml/ref/allfiles.sgml    26 Mar 2008 14:50:28 -0000
***************
*** 145,151 ****
  <!entity dropuser           system "dropuser.sgml">
  <!entity ecpgRef            system "ecpg-ref.sgml">
  <!entity initdb             system "initdb.sgml">
- <!entity ipcclean           system "ipcclean.sgml">
  <!entity pgConfig           system "pg_config-ref.sgml">
  <!entity pgControldata      system "pg_controldata.sgml">
  <!entity pgCtl              system "pg_ctl-ref.sgml">
--- 145,150 ----
Index: src/backend/utils/init/miscinit.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/utils/init/miscinit.c,v
retrieving revision 1.166
diff -c -c -r1.166 miscinit.c
*** src/backend/utils/init/miscinit.c    3 Jan 2008 21:23:15 -0000    1.166
--- src/backend/utils/init/miscinit.c    26 Mar 2008 14:50:28 -0000
***************
*** 841,848 ****
                                          id1, id2),
                                   errhint("If you're sure there are no old "
                                      "server processes still running, remove "
!                                          "the shared memory block with "
!                                       "the command \"ipcclean\", \"ipcrm\", "
                                           "or just delete the file \"%s\".",
                                           filename)));
                  }
--- 841,847 ----
                                          id1, id2),
                                   errhint("If you're sure there are no old "
                                      "server processes still running, remove "
!                                          "the shared memory block "
                                           "or just delete the file \"%s\".",
                                           filename)));
                  }
Index: src/bin/Makefile
===================================================================
RCS file: /cvsroot/pgsql/src/bin/Makefile,v
retrieving revision 1.52
diff -c -c -r1.52 Makefile
*** src/bin/Makefile    18 Mar 2008 16:24:50 -0000    1.52
--- src/bin/Makefile    26 Mar 2008 14:50:28 -0000
***************
*** 13,19 ****
  top_builddir = ../..
  include $(top_builddir)/src/Makefile.global

! DIRS = initdb ipcclean pg_ctl pg_dump \
      psql scripts pg_config pg_controldata pg_resetxlog
  ifeq ($(PORTNAME), win32)
  DIRS+=pgevent
--- 13,19 ----
  top_builddir = ../..
  include $(top_builddir)/src/Makefile.global

! DIRS = initdb pg_ctl pg_dump \
      psql scripts pg_config pg_controldata pg_resetxlog
  ifeq ($(PORTNAME), win32)
  DIRS+=pgevent

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Remove ipcclean
Next
From: Tom Lane
Date:
Subject: Re: \password in psql help