Re: fix in --help output - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: fix in --help output
Date
Msg-id 200803022030.m22KUGY09336@momjian.us
Whole thread Raw
In response to Re: fix in --help output  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-patches
Zdenek Kotala wrote:
> Ups. Patch attached

Tom has applied this patch to CVS HEAD and all relevant back-branches.

---------------------------------------------------------------------------


>
>         Zdenek
>
> Zdenek Kotala napsal(a):
> > Tom Lane napsal(a):
> >> Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> >>> I attached patch which replaces any "--..." occurrence with "-c..."
> >>> on command line.
> >>
> >> Please see whether forcibly using src/port/getopt.c fixes this,
> >> instead.  A saner patch would probably add something like this
> >> to configure.in:
> >>
> >> if test "$PORTNAME" = "solaris"; then
> >> AC_LIBOBJ(getopt)
> >> AC_LIBOBJ(getopt_long)
> >> fi
> >
> > Yeah, this is the best solution. I attach a patch. Is possible to
> > backport it back to 8.3, 8.2?
> >
> > Just for completeness Solaris getopt function has a extension which
> > processes long option argument. This extension is called CLIP. This
> > implementation collides with unusual getopt usage for long option
> > processing in PostgreSQL.
> >
> > More info are there:
> > http://docs.sun.com/app/docs/doc/819-2243/getopt-3c?l=en&a=view
> > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc/port/gen/getopt.c
> >
> > http://docs.sun.com/app/docs/doc/819-2239/6n4hsf6e5?l=en&a=view
> >
> > By the way old solaris getopt version is similary with postgres
> > implementation. :-)
> >
> > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libbc/libc/gen/common/getopt.c
> >
> >
> >
> >         Thanks for help
> >                 Zdenek
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: Don't 'kill -9' the postmaster
>


>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: --describe-config crashes
Next
From: kenneth d'souza
Date:
Subject: Reference by output in : \d