Re: reference problem of manifest.(win32.mak of libpq.dll) - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: reference problem of manifest.(win32.mak of libpq.dll)
Date
Msg-id 20080110150829.GE10183@svr2.hagander.net
Whole thread Raw
In response to Re: reference problem of manifest.(win32.mak of libpq.dll)  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
List pgsql-patches
On Thu, Jan 10, 2008 at 11:52:15PM +0900, Hiroshi Saito wrote:
> Hi.
>
> ----- Original Message -----
> From: "Magnus Hagander" <magnus@hagander.net>
>
>
> >On Wed, Jan 09, 2008 at 04:01:20PM +0900, Hiroshi Saito wrote:
> >>Hi Magnus, and Dave.
> >>
> >>It seems that it is different in nmake although the initial value of
> >>VisualStudio is embedding. Then,  It sees a reference problem by
> >>the dll independent. Therefore, embedding considers like an ideal.
> >>
> >>Please take this into consideration.
> >
> >+ !IF "$(_NMAKE_VER)" != "6.00.9782.0"
> >
> >I don't think that's safe. We need to do a range check. Perhaps check if
> >vesion is >= 7.0 or something?
> >
> >There can be other 6.00.<something> versions, no? Say with different
> >servicepacks or something?
>
> Condition understanding of '>=' is not made as for namke of VC6 to a
> regrettable thing, but it causes an error to it....:-(
> So, except all  thought that it was good.

Hmm. Crap.
Perhaps there's something else we can check on? Like a feature or
environment variable only present in newer versions or something?

/Magnus


pgsql-patches by date:

Previous
From: "Hiroshi Saito"
Date:
Subject: Re: reference problem of manifest.(win32.mak of libpq.dll)
Next
From: Tom Lane
Date:
Subject: Re: Revised patch for fixing archiver shutdown behavior