Postgres Pro
Downloads
Home   >   mailing lists

Re: reference problem of manifest.(win32.mak of libpq.dll) - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: reference problem of manifest.(win32.mak of libpq.dll)
Date
Msg-id 20080110144356.GB10183@svr2.hagander.net
Whole thread Raw
In response to reference problem of manifest.(win32.mak of libpq.dll)  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
List pgsql-patches
Tree view 
On Wed, Jan 09, 2008 at 04:01:20PM +0900, Hiroshi Saito wrote:
> Hi Magnus, and Dave.
>
> It seems that it is different in nmake although the initial value of
> VisualStudio is embedding. Then,  It sees a reference problem by
> the dll independent. Therefore, embedding considers like an ideal.
>
> Please take this into consideration.

+ !IF "$(_NMAKE_VER)" != "6.00.9782.0"

I don't think that's safe. We need to do a range check. Perhaps check if
vesion is >= 7.0 or something?

There can be other 6.00.<something> versions, no? Say with different
servicepacks or something?

//Magnus

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Revised patch for fixing archiver shutdown behavior
Next
From: "Hiroshi Saito"
Date:
Subject: Re: reference problem of manifest.(win32.mak of libpq.dll)