Re: timestamp typedefs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: timestamp typedefs
Date
Msg-id 20080104122026.GA10442@alvh.no-ip.org
Whole thread Raw
In response to Re: timestamp typedefs  ("Warren Turkal" <wturkal@gmail.com>)
Responses Re: timestamp typedefs
List pgsql-hackers
Warren Turkal escribió:
> On Jan 3, 2008 8:54 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > I wrote:
> > > Do we really need "fhour_t" and "fminute_t" on top of "fsec_t"?
> > > This seems like a bad factorization ...
> >
> > After some more thought: I think that what's bugging me is that "fsec_t"
> > is intended to denote "fractional seconds".  The other cases you have
> > here seem not to be intended to be "fractional hours" or "fractional
> > minutes".  I'm not quite sure what the right abstraction is, but it
> > doesn't seem to be that.
> 
> I thought it meant "field seconds". That's why I used fhour_t and
> fminute_t. I'll think about a better name.

Perhaps what you want here is to define a type for calculation results
(double/int64).  Whether it is used in the code for minutes or hours is
irrelevant to the typedef.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Richard Huxton
Date:
Subject: Re: Dynamic Partitioning using Segment Visibility Maps
Next
From: Markus Schiltknecht
Date:
Subject: Re: Dynamic Partitioning using Segment Visibility Maps