Re: [BUGS] BUG #3799: csvlog skips some logs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [BUGS] BUG #3799: csvlog skips some logs
Date
Msg-id 20071210152457.GG8036@alvh.no-ip.org
Whole thread Raw
In response to Re: [BUGS] BUG #3799: csvlog skips some logs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > If it's about what to quote, we need to quote anything that might
> > contain a newline, quote or comma. Filenames certainly come into that
> > category.
> 
> These are not general file paths, these are base names of our own C
> source code files.  I don't have a problem with legislating that we will
> never have such characters in backend source file names ...

Yeah, I was about to say the same thing, but the problem is that the
field is constructed like

function, file:line

so there is a comma anyway.

(We could split it, but since this is only emitted in the
log_error_verbosity=verbose case, I don't think it makes much sense.)

-- 
Alvaro Herrera                         http://www.flickr.com/photos/alvherre/
"I suspect most samba developers are already technically insane...
Of course, since many of them are Australians, you can't tell." (L. Torvalds)


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: O(n^2) aggregates
Next
From: Stephen Frost
Date:
Subject: Re: whats the deal with -u ?