Re: [BUGS] BUG #3799: csvlog skips some logs - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [BUGS] BUG #3799: csvlog skips some logs
Date
Msg-id 20071210151144.GE8036@alvh.no-ip.org
Whole thread Raw
In response to Re: [BUGS] BUG #3799: csvlog skips some logs  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [BUGS] BUG #3799: csvlog skips some logs  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Andrew Dunstan wrote:

> Not sure I understand what this comment I noticed on a very brief glance is 
> about:
>
>  /* assume no newlines in funcname or filename... */
>
> If it's about what to quote, we need to quote anything that might contain a newline, quote or comma. Filenames
certainlycome into that category.
 

Huh, sorry, that's a leftover comment.  The inserted string is quoted
inside appendCSVLiteral.  Thanks, I'll fix it.

-- 
Alvaro Herrera                 http://www.amazon.com/gp/registry/DXLWNGRJD34J
"No es bueno caminar con un hombre muerto"


pgsql-hackers by date:

Previous
From: Gregory Stark
Date:
Subject: O(n^2) aggregates
Next
From: Alvaro Herrera
Date:
Subject: Re: [BUGS] BUG #3799: csvlog skips some logs