pgsql: Code review for LIKE ... - Mailing list pgsql-committers
From | tgl@postgresql.org (Tom Lane) |
---|---|
Subject | pgsql: Code review for LIKE ... |
Date | |
Msg-id | 20071201234444.ED2197540F0@cvs.postgresql.org Whole thread Raw |
List | pgsql-committers |
Log Message: ----------- Code review for LIKE ... INCLUDING INDEXES patch. Fix failure to propagate constraint status of copied indexes (bug #3774), as well as various other small bugs such as failure to pstrdup when needed. Allow INCLUDING INDEXES indexes to be merged with identical declared indexes (perhaps not real useful, but the code is there and having it not apply to LIKE indexes seems pretty unorthogonal). Avoid useless work in generateClonedIndexStmt(). Undo some poorly chosen API changes, and put a couple of routines in modules that seem to be better places for them. Modified Files: -------------- pgsql/src/backend/access/common: reloptions.c (r1.6 -> r1.7) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/reloptions.c?r1=1.6&r2=1.7) pgsql/src/backend/bootstrap: bootparse.y (r1.89 -> r1.90) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/bootstrap/bootparse.y?r1=1.89&r2=1.90) pgsql/src/backend/catalog: pg_depend.c (r1.24 -> r1.25) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_depend.c?r1=1.24&r2=1.25) pgsql/src/backend/commands: indexcmds.c (r1.167 -> r1.168) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/indexcmds.c?r1=1.167&r2=1.168) tablecmds.c (r1.236 -> r1.237) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.236&r2=1.237) pgsql/src/backend/nodes: copyfuncs.c (r1.385 -> r1.386) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.385&r2=1.386) equalfuncs.c (r1.315 -> r1.316) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.315&r2=1.316) outfuncs.c (r1.318 -> r1.319) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.318&r2=1.319) pgsql/src/backend/parser: parse_utilcmd.c (r2.6 -> r2.7) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.6&r2=2.7) pgsql/src/backend/tcop: utility.c (r1.287 -> r1.288) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/utility.c?r1=1.287&r2=1.288) pgsql/src/backend/utils/adt: ruleutils.c (r1.265 -> r1.266) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c?r1=1.265&r2=1.266) pgsql/src/include/access: reloptions.h (r1.3 -> r1.4) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/access/reloptions.h?r1=1.3&r2=1.4) pgsql/src/include/catalog: dependency.h (r1.31 -> r1.32) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/dependency.h?r1=1.31&r2=1.32) pgsql/src/include/commands: defrem.h (r1.86 -> r1.87) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/defrem.h?r1=1.86&r2=1.87) pgsql/src/include/nodes: parsenodes.h (r1.356 -> r1.357) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.356&r2=1.357) pgsql/src/include/utils: builtins.h (r1.306 -> r1.307) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/builtins.h?r1=1.306&r2=1.307) pgsql/src/test/regress/expected: inherit.out (r1.22 -> r1.23) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out?r1=1.22&r2=1.23)
pgsql-committers by date: