Re: pgwin32_open returning EINVAL - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: pgwin32_open returning EINVAL
Date
Msg-id 20071129114843.GG8718@svr2.hagander.net
Whole thread Raw
In response to Re: pgwin32_open returning EINVAL  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pgwin32_open returning EINVAL  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Wed, Nov 28, 2007 at 05:20:46PM +0100, Magnus Hagander wrote:
> On Wed, Nov 28, 2007 at 12:24:26PM -0300, Alvaro Herrera wrote:
> > Martijn van Oosterhout wrote:
> > > On Wed, Nov 28, 2007 at 11:57:35AM -0300, Alvaro Herrera wrote:
> > > > Can we do something like this to report the Win32 error code so that the
> > > > user has a higher chance of figuring out what's going on?
>
> We already do something very similar to what you're donig in
> backend/port/wni32/socket.c :: TranslateSocketError().
>
> So I think it's a good idea to do it, yes.

Thinking about this some more, I think this is a better patch - we already
have a function that takes care of this, including both error and debug
logging. Anybody disagree? If not, I'll go ahead and apply it...

//Magnus


Attachment

pgsql-hackers by date:

Previous
From: "Gevik Babakhani"
Date:
Subject: Re: quotas once again
Next
From: Alvaro Herrera
Date:
Subject: Re: pgwin32_open returning EINVAL