Re: psql -f doesn't complain about directories - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: psql -f doesn't complain about directories
Date
Msg-id 20071114214220.GD13620@svana.org
Whole thread Raw
In response to Re: psql -f doesn't complain about directories  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: psql -f doesn't complain about directories  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Wed, Nov 14, 2007 at 10:25:23PM +0100, Peter Eisentraut wrote:
> Martijn van Oosterhout wrote:
> > To be honest I think that psql shouldn't be ignoring the
> > EISDIR error the kernel is returning.
>
> We use fopen(), which doesn't appear to pass that on.

It's not the fopen that fails, it's the fgets that returns NULL. We
don't subsequently check if that's due to an I/O error or EISDIR or if
it's an end-of-file.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Those who make peaceful revolution impossible will make violent revolution inevitable.
>  -- John F Kennedy

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: psql -f doesn't complain about directories
Next
From: Tom Lane
Date:
Subject: Re: Simplifying Text Search