Re: psql -f doesn't complain about directories - Mailing list pgsql-hackers

From Martijn van Oosterhout
Subject Re: psql -f doesn't complain about directories
Date
Msg-id 20071114211300.GC13620@svana.org
Whole thread Raw
In response to Re: psql -f doesn't complain about directories  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Responses Re: psql -f doesn't complain about directories  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-hackers
On Wed, Nov 14, 2007 at 09:33:17PM +0100, Zdenek Kotala wrote:
> >Sure, why not. To be honest I think that psql shouldn't be ignoring the
> >EISDIR error the kernel is returning.
>
> But it works when you open directory in read-only mode. See posix
> definition:
>
> [EISDIR]
>     The named file is a directory and oflag includes O_WRONLY or O_RDWR.

$ strace psql -f /tmp
<snip>
open("/tmp", O_RDONLY|O_LARGEFILE)      = 4
<snip>
read(4, 0xb7f1b000, 4096)               = -1 EISDIR (Is a directory)

Which is subsequently ignored. I'm hoping it doesn't ignore other
errors, like EIO or EPIPE,

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Those who make peaceful revolution impossible will make violent revolution inevitable.
>  -- John F Kennedy

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Simplifying Text Search
Next
From: Peter Eisentraut
Date:
Subject: Re: psql -f doesn't complain about directories