Re: Preliminary patch for tsearch example dictionaries/pa rsers in contrib - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: Preliminary patch for tsearch example dictionaries/pa rsers in contrib
Date
Msg-id 200710090823550000@1807128900
Whole thread Raw
List pgsql-patches
> Given all the flap about txid, this surely mustn't go in without public
> review first ;-).  So, here is a submission from Sergey Karpov to fill
> in the lack of any working code examples for user-written tsearch
> parsers and dictionaries.
>
> I will be mostly off-line for the next day or so and don't have time to
> work on this more now, but here are a few comments:
>
> * It seems a bit odd to put multiple independent contrib modules under a
> single subfolder.  I'd be inclined to drop the ts_pack layer and just
> make the dictionaries and parser be top-level contrib modules.

Please. Putting multiple modules in the same dir will also break the automatic part of the msvc build parser, requiring
special-casingit. 

/Magnus

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pt_BR FAQ update
Next
From: karpov@sao.ru (Sergey V. Karpov)
Date:
Subject: Re: Preliminary patch for tsearch example dictionaries/parsers in contrib