Re: Not *quite* there on ecpg fixes - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Not *quite* there on ecpg fixes
Date
Msg-id 20071004163529.GQ6176@alvh.no-ip.org
Whole thread Raw
In response to Re: Not *quite* there on ecpg fixes  (Michael Meskes <meskes@postgresql.org>)
Responses Re: Not *quite* there on ecpg fixes
List pgsql-hackers
Michael Meskes wrote:
> On Thu, Oct 04, 2007 at 10:04:41AM -0400, Alvaro Herrera wrote:
> > It looks like dlltool does not like the .def file:
> > ...
> > Line 3 of that file is unadorned "EXPORTS":
> > 
> > echo '; DEF file for MS VC++' > libpgtypesdll.def
> > echo 'LIBRARY LIBPGTYPES' >> libpgtypesdll.def
> > echo 'EXPORTS' >> libpgtypesdll.def
> > ...
> > I wonder why the dlltool failure is not causing the build to fail
> > immediately?
> 
> These lines are simply copied from libpq/Makefile but ddltool does not
> complain while working on libpq. Any idea where they differ?

The libpq exports.txt has spaces, not tabs, as separators.  In fact, if
you see the .def files you notice that the generated files for ecpg are
all wrong.

Simplest is to change tabs to spaces ... However I'm thinking that maybe
it's better to change the sed line to consider both spaces and tabs in
the regex.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


pgsql-hackers by date:

Previous
From: Camilo Porto
Date:
Subject: Re: What does 'elapsed' exact means in PostgreSQL Log Statistics
Next
From: Kris Jurka
Date:
Subject: Re: Not *quite* there on ecpg fixes