Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Date
Msg-id 20071002064145.D9425DCC779@svr2.hagander.net
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
List pgsql-hackers
> > http://www.openssl.org/docs/crypto/ERR_set_mark.html
> > says
> > ERR_set_mark() and ERR_pop_to_mark() were added in OpenSSL 0.9.8.
> 
> > Ooops.  Back to the drawing board.
> 
> To get the buildfarm going again, I applied a patch that turns these
> calls into no-ops if the local OpenSSL hasn't got the functions.
> I'm not entirely sure if the net result is a regression for pre-0.9.8
> OpenSSLs or not --- Magnus, any thoughts on that?
> 

I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99
percentof the messages coming out of that 
 
routine, I bet. And things would still work correct in 0.9.8.

/Magnus



pgsql-hackers by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Next
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL