Re: remove unused "caller" arg from stringToQualifiedNameList - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: remove unused "caller" arg from stringToQualifiedNameList
Date
Msg-id 20070625182531.GC15627@alvh.no-ip.org
Whole thread Raw
In response to Re: remove unused "caller" arg from stringToQualifiedNameList  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: remove unused "caller" arg from stringToQualifiedNameList  ("Jaime Casanova" <systemguards@gmail.com>)
List pgsql-patches
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > This function seems to have an argument that is no longer used (probably
> > leftover from when it used to report an error message?).
>
> Yeah, I recall having left the argument in place because it seemed like
> we might want it again someday.  But that was for 7.4 which was awhile
> ago.  There's probably not a strong argument to keep it, but on the
> other hand is there a strong argument to remove it?

Other than removing cruft, nope, I don't see any ...

In any case, this is an exported symbol so maybe it's not a good idea to
mess with it.  OTOH I checked PL/R and PL/php and neither uses it, so
this may not be a problem at all.

--
Alvaro Herrera                         http://www.flickr.com/photos/alvherre/
"The ability to monopolize a planet is insignificant
next to the power of the source"

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: remove unused "caller" arg from stringToQualifiedNameList
Next
From: Alvaro Herrera
Date:
Subject: remove SIBackendInit return value