pgsql: Remove ruleutils.c's use of varnoold/varoattno as a shortcut for - Mailing list pgsql-committers

From tgl@postgresql.org (Tom Lane)
Subject pgsql: Remove ruleutils.c's use of varnoold/varoattno as a shortcut for
Date
Msg-id 20070524185842.B17389FB8AC@postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Remove ruleutils.c's use of varnoold/varoattno as a shortcut for determining
what a Var node refers to.  This is no longer necessary because the new
flat-range-table representation of plan trees makes it relatively easy to dig
down through child plan levels to find the original reference; and to keep
doing it that way, we'd have to store joinaliasvars lists in flattened RTEs,
as demonstrated by bug report from Leszek Trenkner.  This change makes
varnoold/varoattno truly just debug aids, which wasn't quite the case before.
Perhaps we should drop them, or only have them in assert-enabled builds?

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        ruleutils.c (r1.257 -> r1.258)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c.diff?r1=1.257&r2=1.258)

pgsql-committers by date:

Previous
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Avoid assuming that the fields of struct timeval have exactly
Next
From: eggyknap@pgfoundry.org (User Eggyknap)
Date:
Subject: pgsnmpd - pgsnmpd: Update TODO