Re: Clear up strxfrm() in UTF-8 with locale on Windows - Mailing list pgsql-patches

From ITAGAKI Takahiro
Subject Re: Clear up strxfrm() in UTF-8 with locale on Windows
Date
Msg-id 20070507103222.884A.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Whole thread Raw
In response to Re: Clear up strxfrm() in UTF-8 with locale on Windows  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Clear up strxfrm() in UTF-8 with locale on Windows  ("Magnus Hagander" <magnus@hagander.net>)
List pgsql-patches
Magnus Hagander <magnus@hagander.net> wrote:

> > So actually an equality test against INT_MAX would be correct. But making
> > that clear in the comment would probably not be a bad idea :-)
>
> I have applied a fix for this, because it obviously needed fixing
> regardless of if it fixes the original issue all the way. Still looking
> for confirmation if it does, though.

The fix works well. I tested it with UTF-8 encoding and Japanese_Japan.932
(SJIS) locale and I didn't see any errors. I think it it is enough to cover
the buggy UTF-8 treatment on Windows.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center



pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: Hash function for numeric (WIP)
Next
From: "Magnus Hagander"
Date:
Subject: Re: Clear up strxfrm() in UTF-8 with locale on Windows