Re: Arrays of Complex Types - Mailing list pgsql-hackers

From David Fetter
Subject Re: Arrays of Complex Types
Date
Msg-id 20070402201005.GD29411@fetter.org
Whole thread Raw
In response to Re: Arrays of Complex Types  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Arrays of Complex Types  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
On Fri, Mar 30, 2007 at 05:08:42PM -0400, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > After several rounds of patches, it appears that it might be easier to
> > create a new typtype entry, which I'll tentatively call 'a' because it
> > seems a little fragile and a lot inelegant and hard to maintain to
> > have typtype='c' and typrelid=InvalidOid mean, "this is an array of
> > complex types."
>
> Uh, wouldn't it be typtype = 'c' and typelem != 0 ?

Right.  The attached patch passes the current regression tests and at
least to a "smoke test" level does what it's supposed to do.  I'd
really like to help refactor the whole array system to use 'a', tho.

Cheers,
D
--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778        AIM: dfetter666
                              Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: So are we calling it: Feature Freeze?
Next
From: Tom Lane
Date:
Subject: Re: Questions about pid file creation code