pgsql: Fix array coercion expressions to ensure that the correct - Mailing list pgsql-committers

Log Message:
-----------
Fix array coercion expressions to ensure that the correct volatility is
seen by code inspecting the expression.  The best way to do this seems
to be to drop the original representation as a function invocation, and
instead make a special expression node type that represents applying
the element-type coercion function to each array element.  In this way
the element function is exposed and will be checked for volatility.
Per report from Guillaume Smet.

Modified Files:
--------------
    pgsql/src/backend/catalog:
        dependency.c (r1.64 -> r1.65)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/dependency.c.diff?r1=1.64&r2=1.65)
    pgsql/src/backend/executor:
        execQual.c (r1.215 -> r1.216)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execQual.c.diff?r1=1.215&r2=1.216)
    pgsql/src/backend/nodes:
        copyfuncs.c (r1.371 -> r1.372)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c.diff?r1=1.371&r2=1.372)
        equalfuncs.c (r1.302 -> r1.303)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c.diff?r1=1.302&r2=1.303)
        outfuncs.c (r1.304 -> r1.305)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c.diff?r1=1.304&r2=1.305)
        readfuncs.c (r1.204 -> r1.205)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/readfuncs.c.diff?r1=1.204&r2=1.205)
    pgsql/src/backend/optimizer/path:
        costsize.c (r1.178 -> r1.179)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/costsize.c.diff?r1=1.178&r2=1.179)
    pgsql/src/backend/optimizer/util:
        clauses.c (r1.239 -> r1.240)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/clauses.c.diff?r1=1.239&r2=1.240)
    pgsql/src/backend/parser:
        parse_coerce.c (r2.151 -> r2.152)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_coerce.c.diff?r1=2.151&r2=2.152)
        parse_expr.c (r1.214 -> r1.215)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_expr.c.diff?r1=1.214&r2=1.215)
        parse_func.c (r1.194 -> r1.195)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_func.c.diff?r1=1.194&r2=1.195)
    pgsql/src/backend/utils/adt:
        arrayfuncs.c (r1.137 -> r1.138)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c.diff?r1=1.137&r2=1.138)
        ri_triggers.c (r1.93 -> r1.94)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ri_triggers.c.diff?r1=1.93&r2=1.94)
        ruleutils.c (r1.256 -> r1.257)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c.diff?r1=1.256&r2=1.257)
        selfuncs.c (r1.230 -> r1.231)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/selfuncs.c.diff?r1=1.230&r2=1.231)
    pgsql/src/backend/utils/fmgr:
        fmgr.c (r1.104 -> r1.105)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/fmgr/fmgr.c.diff?r1=1.104&r2=1.105)
    pgsql/src/include/catalog:
        catversion.h (r1.395 -> r1.396)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h.diff?r1=1.395&r2=1.396)
        pg_proc.h (r1.450 -> r1.451)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h.diff?r1=1.450&r2=1.451)
    pgsql/src/include/nodes:
        execnodes.h (r1.170 -> r1.171)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/execnodes.h.diff?r1=1.170&r2=1.171)
        nodes.h (r1.196 -> r1.197)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/nodes.h.diff?r1=1.196&r2=1.197)
        primnodes.h (r1.128 -> r1.129)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/primnodes.h.diff?r1=1.128&r2=1.129)
    pgsql/src/include/parser:
        parse_coerce.h (r1.69 -> r1.70)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/parser/parse_coerce.h.diff?r1=1.69&r2=1.70)
    pgsql/src/include/utils:
        array.h (r1.63 -> r1.64)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/array.h.diff?r1=1.63&r2=1.64)
    pgsql/src/pl/plpgsql/src:
        pl_exec.c (r1.191 -> r1.192)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_exec.c.diff?r1=1.191&r2=1.192)