Re: Arrays of Complex Types - Mailing list pgsql-hackers

From David Fetter
Subject Re: Arrays of Complex Types
Date
Msg-id 20070326013158.GA16551@fetter.org
Whole thread Raw
In response to Arrays of Complex Types  (David Fetter <david@fetter.org>)
Responses Re: Arrays of Complex Types  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:

> I'd like to take the TODO item that reads, "Add support for arrays of
> complex types," but before I start patching, I'd like to see whether
> what I'm about to do makes any sense:

I've written up a patch intended to implement this on the
non-pg_catalog tables and VIEWs, but while it builds, it doesn't
initdb.  Enclosed are the patch and the error log.

Any hints as to what I might look at?

Cheers,
David.

>
> 1.  In src/backend/commands/tablecmds.c, change DefineRelation as
> follows:
>
>     * After the first call to heap_create_with_catalog, construct and
>       do another call to for the array type.
>
>     * Add an appropriate pg_depend entry.
>
> 2.  Change RemoveRelation to reflect the above.
>
> 3.  Change TypeRename appropriately, whatever that turns out to be.
>
> Does the above make sense?  Have I missed anything critical?
>
> Cheers,
> D
> --
> David Fetter <david@fetter.org> http://fetter.org/
> phone: +1 415 235 3778        AIM: dfetter666
>                               Skype: davidfetter
>
> Remember to vote!
> Consider donating to PostgreSQL: http://www.postgresql.org/about/donate
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

--
David Fetter <david@fetter.org> http://fetter.org/
phone: +1 415 235 3778        AIM: dfetter666
                              Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: tsearch2 regression test failures
Next
From: ITAGAKI Takahiro
Date:
Subject: Server-side support of all encodings