Re: [HACKERS] Deadlock with pg_dump? - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Deadlock with pg_dump?
Date
Msg-id 200703021835.l22IZfu03867@momjian.us
Whole thread Raw
In response to Re: [HACKERS] Deadlock with pg_dump?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Deadlock with pg_dump?
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > What are *you* thinking?  Yes, that patch has that line, but
> > log_statement and log_min_duration_statement is going to trigger
> > log_min_error_statement so you are going to get the statement printed
> > twice.
>
> What's wrong with that?  If a statement triggers two different log
> entries, and both are subject to being annotated with the statement text
> according to log_min_error_statement, I would expect them both to be
> annotated.  Doing otherwise will probably break automated log analysis
> tools.

Are people going to be happy that log_statement and
log_min_duration_statement output the statement twice?

    test=> SHOW log_min_error_statement;
     log_min_error_statement
    -------------------------
     error
    (1 row)

    test=> SET log_statement = 'all';
    SET
    test=> SELECT 1;
     ?column?
    ----------
            1
    (1 row)

Server log has:

    LOG:  statement: SELECT 1;
    STATEMENT:  SELECT 1;

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: A little COPY speedup
Next
From: "Simon Riggs"
Date:
Subject: Re: A little COPY speedup